fix: properly print key class #1684

TimoGlastra · 2023-12-27T07:41:40Z

This makes sure that at least in the ConsoleLogger the Key class is printend as the fingerprint property, so we avoid this:

{
    "publicKey": {
      "type": "Buffer",
      "data": [
        67,
        227,
        94,
        17,
        202,
        44,
        168,
        217,
        210,
        62,
        120,
        65,
        119,
        12,
        186,
        150,
        210,
        1,
        153,
        142,
        54,
        158,
        119,
        223,
        138,
        189,
        1,
        4,
        72,
        145,
        192,
        23
      ]
    },
    "keyType": "ed25519"
  }

Signed-off-by: Timo Glastra <[email protected]>

berendsliedrecht · 2023-12-27T12:07:50Z

Won't this cause any issues with the JsonEncoder or any JSON.stringify function?

TimoGlastra · 2023-12-28T09:53:25Z

Yes it will, and I've been thinking about that as well, but you shouldn't really put a Key class into a JsonEncoder or JSON.stringify, so I thought how bad is it in that case if it encodes it to a multibase string (contains both the key type + encoding scheme)? But maybe the toJSON should rather be an object with keytype + publicKeyBase58?

genaris · 2024-01-08T23:05:51Z

But maybe the toJSON should rather be an object with keytype + publicKeyBase58?

I would say this might be more appropriate, as it would return a JSON object as it does today but in a more meaningful way than serializing a buffer instance.

Signed-off-by: Timo Glastra <[email protected]>

TimoGlastra · 2024-01-09T01:44:55Z

I would say this might be more appropriate, as it would return a JSON object as it does today but in a more meaningful way than serializing a buffer instance.

Done ✅

Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]>

Signed-off-by: Ariel Gentile <[email protected]> feat: deliver messages individually, not fetching from the queue every time Signed-off-by: Ariel Gentile <[email protected]> chore: revert to free runners (openwallet-foundation#1662) Signed-off-by: Ry Jones <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: create settings.yml (openwallet-foundation#1663) Signed-off-by: Ry Jones <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: fix ci and add note to readme (openwallet-foundation#1669) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> docs: update active maintainers (openwallet-foundation#1664) Signed-off-by: Karim Stekelenburg <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat: did:peer:2 and did:peer:4 support in DID Exchange (openwallet-foundation#1550) Signed-off-by: Ariel Gentile <[email protected]> feat(presentation-exchange): added PresentationExchangeService (openwallet-foundation#1672) Signed-off-by: Berend Sliedrecht <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: removed jan as maintainer (openwallet-foundation#1678) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> ci: change secret (openwallet-foundation#1679) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: add meta to rxjs timeout errors (openwallet-foundation#1683) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> build(deps): bump ws and @types/ws (openwallet-foundation#1686) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> build(deps): bump follow-redirects from 1.15.2 to 1.15.4 (openwallet-foundation#1694) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: update shared components libraries (openwallet-foundation#1691) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> fix: properly print key class (openwallet-foundation#1684) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat(present-proof): add support for aries RFC 510 (openwallet-foundation#1676) Signed-off-by: Berend Sliedrecht <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> fix(present-proof): isolated tests (openwallet-foundation#1696) Signed-off-by: Ariel Gentile <[email protected]> feat(indy-vdr): register revocation registry definitions and status list (openwallet-foundation#1693) Signed-off-by: Ariel Gentile <[email protected]> chore: rename to credo-ts (openwallet-foundation#1703) Signed-off-by: Ry Jones <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> ci: fix git checkout path and update setup-node (openwallet-foundation#1709) Signed-off-by: Ariel Gentile <[email protected]> fix: remove check for DifPresentationExchangeService dependency (openwallet-foundation#1702) Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> docs: update zoom meeting link (openwallet-foundation#1706) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> refactor(oob)!: make label optional (openwallet-foundation#1680) Signed-off-by: Timo Glastra <[email protected]> Co-authored-by: Ariel Gentile <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat: support short legacy connectionless invitations (openwallet-foundation#1705) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat(dids)!: did caching (openwallet-foundation#1710) feat: did caching Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> fix: jsonld document loader node 18 (openwallet-foundation#1454) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> build(deps): bump amannn/action-semantic-pull-request from 5.3.0 to 5.4.0 (openwallet-foundation#1656) build(deps): bump amannn/action-semantic-pull-request Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.3.0 to 5.4.0. - [Release notes](https://github.com/amannn/action-semantic-pull-request/releases) - [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md) - [Commits](amannn/action-semantic-pull-request@v5.3.0...v5.4.0) --- updated-dependencies: - dependency-name: amannn/action-semantic-pull-request dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat: did rotate (openwallet-foundation#1699) Signed-off-by: Ariel Gentile <[email protected]> refactor: pickup protocol method names Signed-off-by: Ariel Gentile <[email protected]>

fix: properly print key class

94799aa

Signed-off-by: Timo Glastra <[email protected]>

TimoGlastra requested a review from a team as a code owner December 27, 2023 07:41

Merge branch 'main' into fix/properly-print-key

611e246

TimoGlastra requested review from berendsliedrecht and genaris January 8, 2024 02:05

updates

9d73219

Signed-off-by: Timo Glastra <[email protected]>

Merge branch 'main' into fix/properly-print-key

5101101

genaris approved these changes Jan 9, 2024

View reviewed changes

TimoGlastra enabled auto-merge (squash) January 9, 2024 02:11

TimoGlastra merged commit 99b801d into openwallet-foundation:main Jan 9, 2024
7 checks passed

genaris pushed a commit to genaris/credo-ts that referenced this pull request Jan 29, 2024

fix: properly print key class (openwallet-foundation#1684)

dad3d5c

Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: properly print key class #1684

fix: properly print key class #1684

TimoGlastra commented Dec 27, 2023

berendsliedrecht commented Dec 27, 2023

TimoGlastra commented Dec 28, 2023

genaris commented Jan 8, 2024

TimoGlastra commented Jan 9, 2024

fix: properly print key class #1684

fix: properly print key class #1684

Conversation

TimoGlastra commented Dec 27, 2023

berendsliedrecht commented Dec 27, 2023

TimoGlastra commented Dec 28, 2023

genaris commented Jan 8, 2024

TimoGlastra commented Jan 9, 2024